Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Track binary size over time #7005

Merged
merged 4 commits into from
Nov 15, 2016
Merged

Track binary size over time #7005

merged 4 commits into from
Nov 15, 2016

Conversation

kkaefer
Copy link
Member

@kkaefer kkaefer commented Nov 10, 2016

Add logging to CloudWatch that records binary size for Linux, Android, iOS and macOS. In the case of fat binaries, the binary size is split up to individual architectures (iOS/Android) in addition to the default archive.

The idea is that we'll have nightly builds (running in EU early morning) that create a stripped release build to approximate the size of the library in a deployed setting, and record those. Using the data stored in CloudWatch, we'll be able to generate graphs of how the binary size changes over time.

@mention-bot
Copy link

@kkaefer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yhahn, @mikemorris and @tobrun to be potential reviewers.

@kkaefer kkaefer force-pushed the binary-size-metrics branch from ef6720b to 8bd59bb Compare November 10, 2016 15:45
@kkaefer
Copy link
Member Author

kkaefer commented Nov 15, 2016

Can we get this approved so that we can start collecting sizes?

@jfirebaugh jfirebaugh merged commit 1d80be0 into master Nov 15, 2016
@jfirebaugh jfirebaugh deleted the binary-size-metrics branch November 15, 2016 18:07
@jfirebaugh
Copy link
Contributor

@kkaefer Can you record somewhere how to view the CloudWatch history?

@kkaefer
Copy link
Member Author

kkaefer commented Nov 16, 2016

Follow up in #7092

@kkaefer
Copy link
Member Author

kkaefer commented Nov 18, 2016

You can view the binary size log at https://mapbox.github.io/mapbox-gl-native/metrics/binary-size/

@tmpsantos
Copy link
Contributor

@kkaefer this is really nice, could the same idea be used for tracking metrics like memory consumption?

@kkaefer
Copy link
Member Author

kkaefer commented Dec 14, 2016

@tmpsantos yeah; have a look at scripts/log_binary_size.sh. This records an arbitrary number with arbitrary dimensions to CloudWatch, which are then pulled down by scripts/publish_binary_size.sh and are published as a public JSON feed, which are then loaded by the graph page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants